Update task name in notify for a task against name[casing] error
#4038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
audgirka
requested review from
cristianonicolai and
shatakshiiii
and removed request for
a team
ssbarnea
requested changes
Feb 20, 2024
There was a problem hiding this comment.
Based on the example from https://docs.ansible.com/ansible/latest/playbook_guide/playbooks_handlers.html#naming-handlers you will also have to update the 'listen' inside handlers to capitalize it too, or otherwise you will might break notify when it does refer to a topic (instead of name).
ssbarnea
approved these changes
Feb 26, 2024
nrdufour
added a commit
to nrdufour/home-ops
that referenced
this pull request
Mar 14, 2024
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [ansible-lint](https://github.com/ansible/ansible-lint) ([changelog](https://github.com/ansible/ansible-lint/releases)) | patch | `==24.2.0` -> `==24.2.1` | --- ### Release Notes <details> <summary>ansible/ansible-lint (ansible-lint)</summary> ### [`v24.2.1`](https://github.com/ansible/ansible-lint/releases/tag/v24.2.1) [Compare Source](ansible/ansible-lint@v24.2.0...v24.2.1) #### Bugfixes - Fix error suppression when syntax is incorrect ([#​4026](ansible/ansible-lint#4026)) [@​audgirka](https://github.com/audgirka) - Set global `cache_dir_lock` ([#​4055](ansible/ansible-lint#4055)) [@​guppy0130](https://github.com/guppy0130) - \[role-name] Handle string role dependencies ([#​4054](ansible/ansible-lint#4054)) [@​corubba](https://github.com/corubba) - Support for upcoming Ubuntu 24.04 and Fedora 40 ([#​4051](ansible/ansible-lint#4051)) [@​mafalb](https://github.com/mafalb) - Update documentation for syntax-check\[unknown-module] ([#​4049](ansible/ansible-lint#4049)) [@​ssbarnea](https://github.com/ssbarnea) - Add OpenWRT 23.05 to valid versions ([#​4041](ansible/ansible-lint#4041)) [@​jonkerj](https://github.com/jonkerj) - Update task name in `notify` for a task against `name[casing]` error ([#​4038](ansible/ansible-lint#4038)) [@​audgirka](https://github.com/audgirka) - accept yum history and info as valid commands ([#​4025](ansible/ansible-lint#4025)) [@​konstruktoid](https://github.com/konstruktoid) - Add attributes for role argument specs ([#​4018](ansible/ansible-lint#4018)) [@​felixfontein](https://github.com/felixfontein) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNDEuMSIsInVwZGF0ZWRJblZlciI6IjM3LjI0MS4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: Nicolas Dufour <[email protected]> Reviewed-on: https://git.internal/nrdufour/home-ops/pulls/434 Co-authored-by: Renovate <[email protected]> Co-committed-by: Renovate <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #4028