Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support notes and requirements in role entrypoint argument specs #4017

Closed
wants to merge 1 commit into from
Closed

Support notes and requirements in role entrypoint argument specs #4017

wants to merge 1 commit into from

Conversation

felixfontein
Copy link
Contributor

See ansible/ansible#81735 and ansible/ansible#81796.

seealso and version_added is already supported, so there's nothing to do.

@felixfontein felixfontein requested a review from a team as a code owner February 10, 2024 13:11
@felixfontein felixfontein requested review from Qalthos and priyamsahoo and removed request for a team February 10, 2024 13:11
@felixfontein felixfontein mentioned this pull request Feb 10, 2024
Open
@ssbarnea
Copy link
Member

ssbarnea commented May 4, 2024

@felixfontein Can we move this out of draft? LGTM.

@felixfontein
Copy link
Contributor Author

@ssbarnea from my POV yes, since antsibull-docs supported these things for a long time already, but it's not clear which parts ansible-core wants to support or wants to explicitly not support (ansible/ansible#81796 (comment)).

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 24, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@ssbarnea
Copy link
Member

Closing as apparently these are to be deprecated and removed from core. Feel free to reopen if the situation with core changes, I want to minimize the number of lingering PRs.

@ssbarnea ssbarnea closed this Sep 19, 2024
@felixfontein
Copy link
Contributor Author

@ssbarnea do you have any information on this? This has been long possible and fully supported by antsibull-docs, so I don't see why it should be removed.

@felixfontein
Copy link
Contributor Author

Also the core PR is stil open and there has been zero indication there that this is going to be not supported.

@felixfontein felixfontein mentioned this pull request Sep 19, 2024
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssbarnea ssbarnea ssbarnea approved these changes

@Qalthos Qalthos Awaiting requested review from Qalthos Qalthos is a code owner automatically assigned from ansible/devtools

@priyamsahoo priyamsahoo Awaiting requested review from priyamsahoo priyamsahoo is a code owner automatically assigned from ansible/devtools

Assignees
No one assigned
Labels
enhancement upstream
Projects
🧰 devtools project board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@felixfontein @ssbarnea @audgirka