Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid warnings from loading of deprecated modules #3715

Merged
merged 1 commit into from
Nov 27, 2023
Merged

Avoid warnings from loading of deprecated modules #3715

merged 1 commit into from
Nov 27, 2023

Conversation

ssbarnea
Copy link
Member

@ssbarnea ssbarnea commented Sep 5, 2023

  • move module loading code in utils module
  • mimic core behavior and fallback on legacy modules

Fixes: #3696

@ssbarnea ssbarnea requested a review from a team as a code owner September 5, 2023 15:48
@github-actions github-actions bot added the bug label Sep 5, 2023
@ssbarnea ssbarnea changed the title Improve module loading logic Avoid warnings from loading of deprecated modules Sep 5, 2023
@ssbarnea ssbarnea temporarily deployed to ack September 19, 2023 12:55 — with GitHub Actions Inactive
@ssbarnea ssbarnea temporarily deployed to ack September 19, 2023 13:53 — with GitHub Actions Inactive
@ssbarnea ssbarnea temporarily deployed to ack September 28, 2023 12:56 — with GitHub Actions Inactive
cognifloyd
cognifloyd approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@cognifloyd cognifloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

@ssbarnea
Improve module loading logic
9b60765 
- move module loading code in utils module
- mimic core behavior and fallback on legacy modules

Fixes: #3696
@ssbarnea ssbarnea merged commit 99344ca into main Nov 27, 2023
23 checks passed
@ssbarnea ssbarnea deleted the fix/3696 branch November 27, 2023 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cognifloyd cognifloyd cognifloyd approved these changes

@cristianonicolai cristianonicolai Awaiting requested review from cristianonicolai cristianonicolai is a code owner automatically assigned from ansible/devtools

@Qalthos Qalthos Awaiting requested review from Qalthos Qalthos is a code owner automatically assigned from ansible/devtools

@priyamsahoo priyamsahoo Awaiting requested review from priyamsahoo priyamsahoo is a code owner automatically assigned from ansible/devtools

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

WARNING Unable to resolve FQCN for module ansible.builtin.include
2 participants
@ssbarnea @cognifloyd