Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include filepaths starting from $HOME in lintables #3621

Merged
merged 2 commits into from
Jul 19, 2023
Merged

Include filepaths starting from $HOME in lintables #3621

merged 2 commits into from
Jul 19, 2023

Conversation

shatakshiiii
Copy link
Contributor

Fixes: #3615

@shatakshiiii shatakshiiii requested a review from a team as a code owner July 18, 2023 06:29
@github-actions github-actions bot added the bug label Jul 18, 2023
@audgirka
Copy link
Contributor

@shatakshiiii please add a related test.

@shatakshiiii
Copy link
Contributor Author

@shatakshiiii please add a related test.

done!

@audgirka audgirka merged commit 02364fb into ansible:main Jul 19, 2023
@shatakshiiii shatakshiiii deleted the fix/lintables branch July 19, 2023 06:59
nrdufour added a commit to nrdufour/home-ops that referenced this pull request Aug 22, 2023
@nrdufour
chore(deps): update dependency ansible-lint to v6.18.0 (#49)
19cb2d6 
This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [ansible-lint](https://github.com/ansible/ansible-lint) ([changelog](https://github.com/ansible/ansible-lint/releases)) | minor | `==6.17.2` -> `==6.18.0` |

---

### Release Notes

<details>
<summary>ansible/ansible-lint (ansible-lint)</summary>

### [`v6.18.0`](https://github.com/ansible/ansible-lint/releases/tag/v6.18.0)

[Compare Source](ansible/ansible-lint@v6.17.2...v6.18.0)

#### Minor Changes

-   Limit the maximum block depth ([#&#8203;3602](ansible/ansible-lint#3602)) [@&#8203;Ruchip16](https://github.com/Ruchip16)
-   Transform functionality for command_instead_of_shell  ([#&#8203;3675](ansible/ansible-lint#3675)) [@&#8203;ajinkyau](https://github.com/ajinkyau)
-   Add rule to check the number of tasks ([#&#8203;3156](ansible/ansible-lint#3156)) [@&#8203;Ruchip16](https://github.com/Ruchip16)

#### Bugfixes

-   Clarify loop-var-prefix rule and code snippet ([#&#8203;3642](ansible/ansible-lint#3642)) [@&#8203;schwarmco](https://github.com/schwarmco)
-   Update `version_added` for complexity rule ([#&#8203;3623](ansible/ansible-lint#3623)) [@&#8203;ajinkyau](https://github.com/ajinkyau)
-   Ensure that single space between tasks is preserved when using --write ([#&#8203;3641](ansible/ansible-lint#3641)) [@&#8203;shatakshiiii](https://github.com/shatakshiiii)
-   Update ansible-compat used for testing ([#&#8203;3664](ansible/ansible-lint#3664)) [@&#8203;ssbarnea](https://github.com/ssbarnea)
-   Document `yaml[line-length]` rule ([#&#8203;3653](ansible/ansible-lint#3653)) [@&#8203;shatakshiiii](https://github.com/shatakshiiii)
-   Prevent use of spdx-tools 0.8.0 due to breaking changes ([#&#8203;3649](ansible/ansible-lint#3649)) [@&#8203;ssbarnea](https://github.com/ssbarnea)
-   fixes dead marketplace link ([#&#8203;3631](ansible/ansible-lint#3631)) [@&#8203;wookietreiber](https://github.com/wookietreiber)
-   Improve profile information on summary line ([#&#8203;3637](ansible/ansible-lint#3637)) [@&#8203;ziegenberg](https://github.com/ziegenberg)
-   command-instead-of-module: allow `git rev-parse` ([#&#8203;3610](ansible/ansible-lint#3610)) [@&#8203;JohnVillalovos](https://github.com/JohnVillalovos)
-   Include filepaths starting from $HOME in lintables ([#&#8203;3621](ansible/ansible-lint#3621)) [@&#8203;shatakshiiii](https://github.com/shatakshiiii)
-   Update \_mockings.py to fix bug created in [#&#8203;3390](ansible/ansible-lint#3390) ([#&#8203;3614](ansible/ansible-lint#3614)) [@&#8203;karcaw](https://github.com/karcaw)
-   Allow to set gather_facts as templated boolean ([#&#8203;3606](ansible/ansible-lint#3606)) [@&#8203;noonedeadpunk](https://github.com/noonedeadpunk)
-   Add dependency version check for collection metadata ([#&#8203;3601](ansible/ansible-lint#3601)) [@&#8203;ajinkyau](https://github.com/ajinkyau)
-   Fix installation of dependencies when run as an action ([#&#8203;3592](ansible/ansible-lint#3592)) [@&#8203;ssbarnea](https://github.com/ssbarnea)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4yMy4yIiwidXBkYXRlZEluVmVyIjoiMzYuMjMuMiIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Reviewed-on: https://git.home/nrdufour/home-ops/pulls/49
Co-authored-by: Renovate <[email protected]>
Co-committed-by: Renovate <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@audgirka audgirka audgirka approved these changes

@ssbarnea ssbarnea Awaiting requested review from ssbarnea ssbarnea is a code owner automatically assigned from ansible/devtools

@priyamsahoo priyamsahoo Awaiting requested review from priyamsahoo priyamsahoo is a code owner automatically assigned from ansible/devtools

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Lint ignores content when running against home directory path from current directory
2 participants
@shatakshiiii @audgirka