Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid using get_app() from inside the rule #3525

Merged
merged 1 commit into from
Jun 1, 2023
Merged

Avoid using get_app() from inside the rule #3525

merged 1 commit into from
Jun 1, 2023

Commits on Jun 1, 2023

  1. Avoid using get_app() from inside the rule 

    This change does add the app object to the rule collection in order
to make it available to the rules. Also it makes the field_checks
lazy loading, so it would only be initialized much later, after
application was fully initialized.

This fixed a bug observed while running tests in parallel, where
app was initialized multiple times causing conflicts with collection
installation.
    @ssbarnea
    ssbarnea committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    aec9a5d View commit details
    Browse the repository at this point in the history