Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve tests related to vault processing #3306

Merged
merged 2 commits into from
Apr 19, 2023
Merged

Improve tests related to vault processing #3306

merged 2 commits into from
Apr 19, 2023

Conversation

ssbarnea
Copy link
Member

@ssbarnea ssbarnea commented Apr 19, 2023

As we were not able to reproduce the original bug #2504, we add a test for it and close it, so
we would prevent it from resurfacing later.

Fixes: #2506

@github-actions github-actions bot added the bug label Apr 19, 2023
@ssbarnea ssbarnea changed the title Improve vault processing Improve tests related to vault processing Apr 19, 2023
@ssbarnea ssbarnea marked this pull request as ready for review April 19, 2023 10:44
@ssbarnea ssbarnea requested a review from a team as a code owner April 19, 2023 10:44
@ssbarnea ssbarnea requested review from a team, audgirka, shatakshiiii and Ruchip16 April 19, 2023 10:44
@ssbarnea ssbarnea merged commit e5d67f5 into main Apr 19, 2023
@ssbarnea ssbarnea deleted the fix/log branch April 19, 2023 12:26
@ktomk
Copy link

ktomk commented Apr 19, 2023

Thank you!

@@ -1,3 +1,4 @@
---
Copy link

@pascal-hofmann pascal-hofmann Jun 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding the document start breaks ansible-vault for me:

ERROR! input is not vault encrypted data. …
% ansible-vault --version
ansible-vault [core 2.14.5]
  python version = 3.11.3
  jinja version = 3.1.2
  libyaml = False

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants