Require at least one known subfolder for roles #3303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Identified folders as roles only if they contain one of the known subfolders used by roles, such "tasks", "meta", "vars", "defaults", "handlers".
ssbarnea
force-pushed
the
feat/role-subfolder
branch
from
7d8f9c1
to
e1f2974
Compare
|
Please note that "eco" pipeline failure seems expected in this case, as it does change the output for debops repository. |
audgirka
approved these changes
Apr 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identified folders as roles only if they contain one of the known subfolders used by roles, such "tasks", "meta", "vars", "defaults", "handlers".
This behaviour change should prevent undesired identification of other folders as roles, like we seen on debops repository, where documentation folders were wrongly identified as roles.