Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow a prefix in subtasks names #2740

Merged
merged 1 commit into from
Dec 2, 2022
Merged

Allow a prefix in subtasks names #2740

merged 1 commit into from
Dec 2, 2022

Conversation

shatakshiiii
Copy link
Contributor

@shatakshiiii shatakshiiii commented Nov 25, 2022 •
edited
Loading

ssbarnea
ssbarnea requested changes Nov 25, 2022
View reviewed changes
Copy link
Member

@ssbarnea ssbarnea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment

@shatakshiiii shatakshiiii force-pushed the nameCasing branch 4 times, most recently from da57b58 to 3bbc429 Compare December 2, 2022 06:58
@shatakshiiii shatakshiiii marked this pull request as ready for review December 2, 2022 09:05
cidrblock
cidrblock approved these changes Dec 2, 2022
View reviewed changes
Copy link
Contributor

@cidrblock cidrblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for _collection and the test coverage looks good

@ssbarnea ssbarnea added bug and removed enhancement labels Dec 2, 2022
@ssbarnea ssbarnea changed the title Allow prefix in combination with task name Allow a prefix in subtasks names Dec 2, 2022
@ssbarnea ssbarnea merged commit 7e56890 into ansible:main Dec 2, 2022
@shatakshiiii shatakshiiii deleted the nameCasing branch February 6, 2023 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cidrblock cidrblock cidrblock approved these changes

@ssbarnea ssbarnea ssbarnea approved these changes

@audgirka audgirka Awaiting requested review from audgirka audgirka is a code owner automatically assigned from ansible/devtools

@priyamsahoo priyamsahoo Awaiting requested review from priyamsahoo priyamsahoo is a code owner automatically assigned from ansible/devtools

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rule name[casing] conflicts with COP 3.1.16
3 participants
@shatakshiiii @ssbarnea @cidrblock