Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat ansible.legacy the same way ansible.builtin #2727

Merged
merged 3 commits into from
Nov 24, 2022

Conversation

evgeni
Copy link
Contributor

@evgeni evgeni commented Nov 24, 2022

No description provided.

@evgeni evgeni requested a review from a team as a code owner November 24, 2022 08:33
@evgeni
Copy link
Contributor Author

evgeni commented Nov 24, 2022

"Coverage failure: total of 87 is less than fail-under=88" -- it's still one statement, why would the coverage be lower than before?

@ssbarnea ssbarnea added the bug label Nov 24, 2022
@ssbarnea ssbarnea changed the title Also accept ansible.legacy as a valid builtin alias Treat ansible.legacy the same way ansible.builtin Nov 24, 2022
@ssbarnea
Copy link
Member

"Coverage failure: total of 87 is less than fail-under=88" -- it's still one statement, why would the coverage be lower than before?

It can happen but is quite rare, safe to ignore it.

@ssbarnea ssbarnea merged commit ca261e2 into ansible:main Nov 24, 2022
@evgeni evgeni deleted the only-legacy branch November 25, 2022 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants