-
Notifications
You must be signed in to change notification settings - Fork 660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make SARIF output specification compliant #2668
Conversation
for more information, see https://pre-commit.ci
This failed test doesn't appear to have been introduced by my changes as it's failing in other PRs and on the mainline branch as well:
|
You are right. Someone needs to fix that test before we can merge the other PRs. I am currently in vacation for another week so I am not sure if I will find time to do it myself. |
The test that's failing in the |
The implementation uses the (unique) tag value instead of the rule ID.
Fixes: #2667