Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

no-shorthand: Avoid false positive with raw #2541

Merged
merged 1 commit into from
Oct 3, 2022
Merged

no-shorthand: Avoid false positive with raw #2541

merged 1 commit into from
Oct 3, 2022

Conversation

ssbarnea
Copy link
Member

@ssbarnea ssbarnea commented Oct 3, 2022 •
edited
Loading

  • Add special case for raw, where we would look for executable= string
  • Add warning if we see raw being called with anything else than a string

Fixes: #2537

@ssbarnea ssbarnea requested a review from a team as a code owner October 3, 2022 10:18
@ssbarnea ssbarnea requested review from a team, ganeshrn, audgirka and trishnaguha October 3, 2022 10:18
@github-actions github-actions bot added the bug label Oct 3, 2022
@hswong3i
Copy link
Contributor

hswong3i commented Oct 3, 2022

Do we need examples and test cases for this, too?

@ssbarnea
Copy link
Member Author

ssbarnea commented Oct 3, 2022

Do we need examples and test cases for this, too?

I just pushed a new revision, with tests and updated examples. Good idea!

@ssbarnea ssbarnea merged commit ac20220 into ansible:main Oct 3, 2022
@ssbarnea ssbarnea deleted the fix/proj_dir branch October 3, 2022 12:23
@ssbarnea ssbarnea mentioned this pull request Oct 3, 2022
Merged
ssbarnea added a commit to ssbarnea/ansible-lint that referenced this pull request Oct 5, 2022
@ssbarnea
no-shorthand: Avoid false positive with raw (ansible#2541)
5b696a5 
Fixes: ansible#2537
@ssbarnea ssbarnea added skip-changelog Can be missed from the changelog. and removed bug labels Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ganeshrn ganeshrn Awaiting requested review from ganeshrn ganeshrn is a code owner automatically assigned from ansible/devtools

@audgirka audgirka Awaiting requested review from audgirka audgirka is a code owner automatically assigned from ansible/devtools

@trishnaguha trishnaguha Awaiting requested review from trishnaguha trishnaguha is a code owner automatically assigned from ansible/devtools

Assignees
No one assigned
Labels
skip-changelog Can be missed from the changelog.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

no-shorthand + ansible.builtin.raw: The raw module takes a free form command to run.
2 participants
@ssbarnea @hswong3i