Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds summary stats about found violations #2495

Merged
merged 1 commit into from
Sep 29, 2022

Conversation

ssbarnea
Copy link
Member

@ssbarnea ssbarnea commented Sep 25, 2022

Fixes: #2110

sample-screenshot

@ssbarnea ssbarnea requested a review from a team as a code owner September 25, 2022 14:05
@github-actions github-actions bot added the bug label Sep 25, 2022
Copy link

@briantist briantist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A warning that I'm not too familiar with this codebase, but the results look nice to me and nothing stands out to me on the implementation side. Thanks!

@ssbarnea
Copy link
Member Author

A warning that I'm not too familiar with this codebase, but the results look nice to me and nothing stands out to me on the implementation side. Thanks!

Thanks! I was interested in opinions regarding the output in particular. I wanted to avoid making it too verbose, but also keep it usable. The rules are ordered by importance (profile), not count. If you address them from the top the scoring can increase.

@ssbarnea ssbarnea added this to the 6.8.0 milestone Sep 27, 2022
@ssbarnea ssbarnea added enhancement and removed bug labels Sep 29, 2022
@ssbarnea ssbarnea merged commit c335b57 into ansible:main Sep 29, 2022
@ssbarnea ssbarnea deleted the fix/summary branch September 29, 2022 20:36
ssbarnea added a commit to ssbarnea/ansible-lint that referenced this pull request Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support to display score on running lint for a given profile
2 participants