Ensure that symlinked arguments are resolved #2476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssbarnea
requested review from
a team,
ganeshrn,
priyamsahoo and
shatakshiiii
ssbarnea
force-pushed
the
fix/relpath
branch
2 times, most recently
from
2d314b9
to
f563b78
Compare
- Fixes bug where a giving a symlinked directory as argument would fail to lint the entire role, basically because the linter failed to resolve the link before processing all lintables within it. - Ensure we resolve symlink in Lintable constructor - Add normalization function that returns a Path
ssbarnea
force-pushed
the
fix/relpath
branch
from
f563b78
to
b1eba2e
Compare
davedittrich
pushed a commit
to davedittrich/ansible-lint
that referenced
this pull request
Sep 27, 2022
- Fixes bug where a giving a symlinked directory as argument would fail to lint the entire role, basically because the linter failed to resolve the link before processing all lintables within it. - Ensure we resolve symlink in Lintable constructor - Add normalization function that returns a Path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fail to lint the entire role, basically because the linter failed
to resolve the link before processing all lintables within it.