Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark galaxy rule as required only for shared profile #2441

Merged
merged 1 commit into from
Sep 18, 2022
Merged

Mark galaxy rule as required only for shared profile #2441

merged 1 commit into from
Sep 18, 2022

Conversation

ssbarnea
Copy link
Member

@ssbarnea ssbarnea commented Sep 18, 2022 •
edited
Loading

  • makes galaxy rule opt-in, so it would not be executed when a profile does not ask for it
  • adds galaxy rule to shared profile, so we check requirements when before uploading (production profile inherits shared one)

@ssbarnea ssbarnea requested a review from a team as a code owner September 18, 2022 16:28
@ssbarnea ssbarnea added the bug label Sep 18, 2022
@ssbarnea
Mark galaxy rule as required only for shared profile
fac6c3e 
- makes galaxy rule opt-in, so it would not be executed when a profile
  is not selected
- adds galaxy rule to shared profile, so we check requirements when
  before uploading (production profile inherits shared one)
@ssbarnea ssbarnea added this to the 6.6.0 milestone Sep 18, 2022
@ssbarnea ssbarnea merged commit 76317f1 into ansible:main Sep 18, 2022
@ssbarnea ssbarnea deleted the fix/jinja-template-lookup branch September 18, 2022 18:27
davedittrich pushed a commit to davedittrich/ansible-lint that referenced this pull request Sep 27, 2022
@ssbarnea @davedittrich
Mark galaxy rule as required only for shared profile (ansible#2441)
6328e5b 
- makes galaxy rule opt-in, so it would not be executed when a profile
  is not selected
- adds galaxy rule to shared profile, so we check requirements when
  before uploading (production profile inherits shared one)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ganeshrn ganeshrn Awaiting requested review from ganeshrn ganeshrn is a code owner automatically assigned from ansible/devtools

@cidrblock cidrblock Awaiting requested review from cidrblock cidrblock is a code owner automatically assigned from ansible/devtools

@shatakshiiii shatakshiiii Awaiting requested review from shatakshiiii shatakshiiii is a code owner automatically assigned from ansible/devtools

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
6.6.0
Development

Successfully merging this pull request may close these issues.
1 participant
@ssbarnea