deprecated-module: add documentation #2377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
ssbarnea
changed the title
|
@oraNod BTW, I replaced your original comment from the description because it was not suitable for a commit message. Because we merge with squash, bug title/description become commit message, so we often need to alter them. That first contribution was flawless! Good example and explanation, clearly will help few users. I will merge it as soon GHA is passing. |
|
Thanks @ssbarnea ! I'll keep the description in mind for my next PR. |
|
In fact I was wrong, only the title is used. The merge message is combined from the commits, so forget about my comment. |
This was referenced Sep 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds examples and extra documentation to this rule.