Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve install_collection implementation #1637

Merged
merged 1 commit into from
Jun 24, 2021
Merged

Improve install_collection implementation #1637

merged 1 commit into from
Jun 24, 2021

Conversation

ssbarnea
Copy link
Member

@ssbarnea ssbarnea commented Jun 18, 2021

  • assure at default verbosity we do log ansible-galaxy command ran (info level is not logged by default)
  • add ability to specify destination for install_collection
  • assure we inject our own cache to top of collection path when present
  • allow use of require_collection without a cache folder.

Note: this is likely the last change made to prerun code before moving this code into newly created standalone library ansible/ansible-compat#4

@ssbarnea ssbarnea added the bug label Jun 18, 2021
@ssbarnea ssbarnea force-pushed the fix/prerun branch 3 times, most recently from cc34b97 to eb1efd5 Compare June 22, 2021 08:33
@ssbarnea ssbarnea requested a review from tadeboro June 22, 2021 09:30
src/ansiblelint/prerun.py Outdated Show resolved Hide resolved
- assure at default verbosity we do log ansible-galaxy command ran
- add ability to specify destination for install_collection
- assure we inject our own cache to top of collection path
- allow use of require_collection without a cache folder.
@ssbarnea ssbarnea merged commit 57a6d5b into master Jun 24, 2021
@ssbarnea ssbarnea deleted the fix/prerun branch June 24, 2021 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants