Add rule for checking no_log is set when passwords are used

[noonedeadpunk]

It's pretty important to ensure, that password won't be logged
and thus exposed in the output. So we add linter rule that will
check that all tasks, that have "password" in argument are not logged.

Signed-Off-By: Dmitriy Rabotyagov [email protected]

[ssbarnea]

You still need to: increase number of rules from 39 to 40 (specific test that fails). For lint I am sure you know how to test locally (tox -e lint).

[noonedeadpunk]

Not sure how to satisfy Codacy Static Code Analysis though. As it seems other rules are set the same way with same issues, but it's not complaining about them

[ssbarnea]

Not sure how to satisfy Codacy Static Code Analysis though. As it seems other rules are set the same way with same issues, but it's not complaining about them

You can fully ignore Codacy is there only as an experiment, but the others must pass, especially the unittesting. Run locally with tox -e py39-core or similar and if it passed you should be fine.

[noonedeadpunk]

Yep, also saw things failing, but barely understand why tbh. As how good_runner.run() could result in [no-log-password] (password should not be[270 chars]True

[ssbarnea]

Yep, also saw things failing, but barely understand why tbh. As how good_runner.run() could result in [no-log-password] (password should not be[270 chars]True

I fixed them.