Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow user to make yamllint rule mandatory #1543

Merged
merged 1 commit into from
May 3, 2021
Merged

Allow user to make yamllint rule mandatory #1543

merged 1 commit into from
May 3, 2021

Conversation

ssbarnea
Copy link
Member

@ssbarnea ssbarnea commented May 3, 2021 •
edited
Loading

Closes: #1538

@ssbarnea ssbarnea mentioned this pull request May 3, 2021
Closed
@ssbarnea ssbarnea merged commit 7a3fcc8 into master May 3, 2021
@ssbarnea ssbarnea deleted the fix/require-yaml branch May 3, 2021 12:02
dosmanak
dosmanak reviewed May 3, 2021
View reviewed changes
src/ansiblelint/rules/YamllintRule.py
@@ -38,6 +43,10 @@
Specific tag identifiers that are printed at the end of rule name,
like 'trailing-spaces' or 'indentation' can also be be skipped, allowing
you to have a more fine control.

By default this rule is not used hwne yamllint library is missing. If you want
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo "hwne" => "when"

@dosmanak
Copy link

dosmanak commented May 3, 2021

This change does not solve the non-deterministic behaviour on yamllint presence in the system :-(

@ssbarnea
Copy link
Member Author

ssbarnea commented May 3, 2021

@dosmanak It does, if you add the now documented rule. On the other hand, if you want deterministic results, you could opt for using a container. Different results were caused by different environments, that was not really a bug in the linter.

@dosmanak
Copy link

dosmanak commented May 4, 2021

I still do not understand the default behaviour.
When the yamllint is present it is used, whilst if missing it fails silently. Why have you chose such illogical approach? Perhaps I am the only one who feels that way and I will not push the discussion further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dosmanak dosmanak dosmanak left review comments

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ssbarnea @dosmanak