Avoid pre-run errors when role-name is disabled #1459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssbarnea
requested review from
geerlingguy,
awcrosby,
tadeboro and
felixfontein
ssbarnea
added
the
feedback-needed
- when `role-name` is added to skip_list, just install simple role name - when `role-name` is added to warn_list, display warning and continue execution. Fixes: #1454
ssbarnea
removed
the
feedback-needed
awcrosby
approved these changes
Mar 11, 2021
This was referenced Mar 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
role-nameis added to skip_list, just install simple role namerole-nameis added to warn_list, display warning and continue execution.role-namerule is now moved to default warn_list, so users that do not have custom warn list, will only see its reported violations but the linter will report success.Fixes: #1454