Fallback to syntax-check if ansible-lint is not installed or disabled

src/ansibleLanguageService.ts

@@ -143,7 +143,13 @@ export class AnsibleLanguageService {
         const context = this.workspaceManager.getContext(e.document.uri);
         if (context) {
           // perform full validation
-          await doValidate(e.document, this.validationManager, false, context);
+          await doValidate(
+            e.document,
+            this.validationManager,
+            false,
+            context,
+            this.connection
+          );
         }
       } catch (error) {
         this.handleError(error, 'onDidOpen');
@@ -177,7 +183,13 @@ export class AnsibleLanguageService {
         const context = this.workspaceManager.getContext(e.document.uri);
         if (context) {
           // perform full validation
-          await doValidate(e.document, this.validationManager, false, context);
+          await doValidate(
+            e.document,
+            this.validationManager,
+            false,
+            context,
+            this.connection
+          );
         }
       } catch (error) {
         this.handleError(error, 'onDidSave');
@@ -201,7 +213,8 @@ export class AnsibleLanguageService {
           e.document,
           this.validationManager,
           true,
-          this.workspaceManager.getContext(e.document.uri)
+          this.workspaceManager.getContext(e.document.uri),
+          this.connection
         );
       } catch (error) {
         this.handleError(error, 'onDidChangeContent');

src/providers/validationProvider.ts

@@ -1,6 +1,7 @@
 import IntervalTree from '@flatten-js/interval-tree';
 import * as _ from 'lodash';
 import {
+  Connection,
   Diagnostic,
   DiagnosticRelatedInformation,
   DiagnosticSeverity,
@@ -24,7 +25,8 @@ export async function doValidate(
   textDocument: TextDocument,
   validationManager: ValidationManager,
   quick = true,
-  context?: WorkspaceFolderContext
+  context?: WorkspaceFolderContext,
+  connection?: Connection
 ): Promise<Map<string, Diagnostic[]>> {
   let diagnosticsByFile;
   if (quick || !context) {
@@ -45,7 +47,16 @@ export async function doValidate(
       diagnosticsByFile = await context.ansibleLint.doValidate(textDocument);
     }
 
-    if (!diagnosticsByFile || !lintAvailability) {
+    if (!diagnosticsByFile || !lintAvailability || diagnosticsByFile === -1) {
+      // Notifying the user about the failed ansible-lint command and falling back to ansible syntax-check in this scenario
+      if (diagnosticsByFile === -1) {
+        console.debug(
+          'Ansible-lint command execution failed. Falling back to ansible syntax-check'
+        );
+        connection.window.showInformationMessage(
+          'Falling back to ansible syntax-check.'
+        );
+      }
       console.debug('Validating using ansible syntax-check');
       diagnosticsByFile = await context.ansiblePlaybook.doValidate(
         textDocument

src/services/ansibleLint.ts

@@ -50,7 +50,7 @@ export class AnsibleLint {
    */
   public async doValidate(
     textDocument: TextDocument
-  ): Promise<Map<string, Diagnostic[]>> {
+  ): Promise<Map<string, Diagnostic[]> | -1> {
     let diagnostics: Map<string, Diagnostic[]> = new Map();
 
     const workingDirectory = URI.parse(this.context.workspaceFolder.uri).path;
@@ -136,15 +136,8 @@ export class AnsibleLint {
               workingDirectory
             );
           } else {
-            // Notifying the user about the failed command and falling back to ansible syntax-check in this scenario
-            this.connection.window.showWarningMessage(
-              'Falling back to ansible syntax-check.'
-            );
             this.connection.window.showErrorMessage(execError.message);
-            console.debug(
-              'Ansible-lint command execution failed. Falling back to ansible syntax-check'
-            );
-            return;
+            return -1;
           }
 
           if (execError.stderr) {

src/utils/misc.ts

@@ -5,8 +5,6 @@ import { promisify } from 'util';
 import { TextDocument } from 'vscode-languageserver-textdocument';
 import { Range } from 'vscode-languageserver-types';
 import * as path from 'path';
-import * as child_process from 'child_process';
-import { promisify } from 'util';
 
 export async function fileExists(fileUri: string): Promise<boolean> {
   return !!(await fs.stat(new URL(fileUri)).catch(() => false));