Skip to content
This repository has been archived by the owner on Oct 9, 2024. It is now read-only.

Update settings to disable validation #448

Merged
merged 5 commits into from
Oct 3, 2022

Conversation

priyamsahoo
Copy link
Contributor

@priyamsahoo priyamsahoo commented Oct 1, 2022

The PR updates the code to support settings to disable validation.

  • Removed settings:

    1. ansible.ansibleLint.enabled
    2. ansible.ansibleLint.path
    3. ansible.ansibleLint.arguments
  • Added settings:

    1. ansible.validation.enabled
    2. ansible.validation.lint.enabled
    3. ansible.validation.lint.path
    4. ansible.validation.lint.agruments

NOTE:

  • Subsequent changes will be added in the vscode-ansible repository to use this.
  • The CI job task/vscode is expected to fail.

@yaegassy, @fredericgiquel you can update your clients to support this once merged.

@priyamsahoo priyamsahoo changed the title Update settings to disable validation [DNM]: Update settings to disable validation Oct 1, 2022
@priyamsahoo priyamsahoo added the enhancement New feature or request label Oct 1, 2022
@priyamsahoo priyamsahoo marked this pull request as ready for review October 1, 2022 06:10
@priyamsahoo priyamsahoo requested review from a team and tomaciazek as code owners October 1, 2022 06:10
@priyamsahoo priyamsahoo changed the title [DNM]: Update settings to disable validation Update settings to disable validation Oct 1, 2022
@fredericgiquel
Copy link
Contributor

All right, got it.
I will update settings in Emacs LSP Client after the next release with this branch merged.

Copy link
Member

@ganeshrn ganeshrn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it is a breaking change please update the major version for both ALS and vscode-ansible extension

@priyamsahoo priyamsahoo enabled auto-merge (squash) October 3, 2022 10:45
@priyamsahoo priyamsahoo merged commit c4f80b2 into ansible:main Oct 3, 2022
@priyamsahoo priyamsahoo deleted the server-disable-linting branch October 3, 2022 10:46
github-actions bot pushed a commit that referenced this pull request Oct 4, 2022
## v1.0.0

### Minor Changes

- Update settings to disable validation (#448) @priyamsahoo

### Bugfixes

- Fix bug related to diagnostics caching when validation is disabled (#451) @priyamsahoo
@ansibot ansibot mentioned this pull request Oct 4, 2022
ssbarnea pushed a commit that referenced this pull request Oct 4, 2022
## v1.0.0

### Minor Changes

- Update settings to disable validation (#448) @priyamsahoo

### Bugfixes

- Fix bug related to diagnostics caching when validation is disabled (#451) @priyamsahoo

Co-authored-by: Ansible DevTools <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants