This repository has been archived by the owner on Oct 9, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
priyamsahoo
changed the title
Update settings to disable validation
[DNM]: Update settings to disable validation
Oct 1, 2022
priyamsahoo
force-pushed
the
server-disable-linting
branch
from
October 1, 2022 03:08
f99dd15
to
3cde4d6
Compare
priyamsahoo
changed the title
[DNM]: Update settings to disable validation
Update settings to disable validation
Oct 1, 2022
priyamsahoo
force-pushed
the
server-disable-linting
branch
from
October 1, 2022 07:37
a5bb546
to
c433849
Compare
All right, got it. |
ganeshrn
reviewed
Oct 1, 2022
ganeshrn
reviewed
Oct 1, 2022
ganeshrn
approved these changes
Oct 3, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since it is a breaking change please update the major version for both ALS and vscode-ansible extension
github-actions bot
pushed a commit
that referenced
this pull request
Oct 4, 2022
## v1.0.0 ### Minor Changes - Update settings to disable validation (#448) @priyamsahoo ### Bugfixes - Fix bug related to diagnostics caching when validation is disabled (#451) @priyamsahoo
Merged
ssbarnea
pushed a commit
that referenced
this pull request
Oct 4, 2022
## v1.0.0 ### Minor Changes - Update settings to disable validation (#448) @priyamsahoo ### Bugfixes - Fix bug related to diagnostics caching when validation is disabled (#451) @priyamsahoo Co-authored-by: Ansible DevTools <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR updates the code to support settings to disable validation.
Removed settings:
ansible.ansibleLint.enabled
ansible.ansibleLint.path
ansible.ansibleLint.arguments
Added settings:
ansible.validation.enabled
ansible.validation.lint.enabled
ansible.validation.lint.path
ansible.validation.lint.agruments
NOTE:
task/vscode
is expected to fail.@yaegassy, @fredericgiquel you can update your clients to support this once merged.