Skip to content
This repository has been archived by the owner on Oct 9, 2024. It is now read-only.

Check that module paths are directories before globbing them #38

Merged
merged 3 commits into from
Sep 29, 2021

Conversation

kimbernator
Copy link
Contributor

@kimbernator kimbernator commented Sep 22, 2021

I found that easy-install had added a .egg file to my python path, which then caused the language server to barf when it tried to glob "my_file.egg/**/whatever". This just adds an early return for when the path exists and is found to be a file in the two cases where it seems to matter.

@ganeshrn ganeshrn requested review from tomaciazek and a team September 28, 2021 04:10
@ganeshrn
Copy link
Member

/cc @yaegassy For review from coc.nvim extension perspective.

@yaegassy
Copy link
Contributor

/cc @yaegassy For review from coc.nvim extension perspective.

I have no particular opinion. I'll leave it to the "vscode-ansible/ansible-language-server" team 🙇

Copy link
Contributor

@tomaciazek tomaciazek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ssbarnea ssbarnea added the bug Something isn't working label Sep 29, 2021
@ssbarnea ssbarnea merged commit dc1680f into ansible:main Sep 29, 2021
@webknjaz
Copy link
Member

I found that easy-install had added

Side note — @kimbernator you know that easy_install is at least half a decade deprecated thing with a lot of problems, right? Better not use it in the future.

@kimbernator
Copy link
Contributor Author

kimbernator commented Oct 28, 2021

@webknjaz Yep, not a concern. These files were just left over from running easy_install once or twice before understanding that it was deprecated. This still felt like a worthwhile addition in case other files work their way into that directory.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants