Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: refresh dev dependencies #379

Merged
merged 1 commit into from
Sep 11, 2023
Merged

ci: refresh dev dependencies #379

merged 1 commit into from
Sep 11, 2023

Conversation

github-actions[bot]
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the dependency_update PR to update pinned dependencies label Sep 11, 2023
@gotmax23 gotmax23 closed this Sep 11, 2023
@gotmax23 gotmax23 reopened this Sep 11, 2023
@github-actions github-actions bot added the needs_triage Needs a first human triage before being processed. label Sep 11, 2023
@gotmax23 gotmax23 merged commit 87b8858 into devel Sep 11, 2023
@gotmax23 gotmax23 deleted the pip-compile/devel/dev branch September 11, 2023 17:24
@samccann
Copy link
Contributor

@gotmax23 - we shouldn't be merging dependency changes w/o proof of testing. (I'm unfamiliar with what black does and if it hits the docs build or something else). Can you post how you tested this before merging?

Can you also clarify if this impacts something other than the docs builds?

@gotmax23
Copy link
Collaborator

The "refresh dev dependencies" and "refresh docs dependencies" PRs are two different things.

The dev dependencies do not affect the docs builds in any way. The only thing they affect are python linters (black, ruff, isort, mypy) that only touch two files1: hacking/pr_labeler/label.py and noxfile.py. I have been acking and merging those once CI passes as we already discussed. There's nothing to test. The files either pass the linters or they require changes.

I have been leaving the docs build dependencies to you and @oraNod to review, test, and merge after there have been at least two approvals. Those are not being backported and are being handled as separate PRs.

Footnotes

  1. I would like to apply these rules to the other Python code in this repository but have not yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependency_update PR to update pinned dependencies needs_triage Needs a first human triage before being processed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants