-
Notifications
You must be signed in to change notification settings - Fork 543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump sphinx to 6.2.1 on devel #320
Conversation
6edeb69
to
a1af708
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good now, but let's wait to merge it until we can do a test Jenkins build. Also note that this may conflict with the sphinx-intl PR. You'll probably need to re-run pip-compile or manually resolve conflicts after merging the first one. It might be better to submit a single PR so everything can be tested and acked in one go.
Thanks @gotmax23 I'm going to build this on test today and would like to get it merged separately to the |
I've tested this in a jenkins build and it is successful. Here are the full logs: https://gist.githubusercontent.com/oraNod/ca315a3e2f51e4fbcb3b4926264d8b49/raw/fd09859cca342af2ef9e5d39a71745b7f7378092/gistfile1.txt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just putting a hold on this until I can verify the output as it's a major version change to sphinx.
Don's pr up on test if anyone else wants to get eyes on it - http://docs.testing.ansible.com/ansible/devel/index.html |
Also for those looking - changelog for sphinx 6.2.1 - https://www.sphinx-doc.org/en/master/changes.html#release-6-2-1-released-apr-25-2023 Read all the way back to 5.3.0 as that's what we currently use. |
@oraNod a comment in chat asked if we can jump straight to 7.1.2? |
Now looking similar to #329 so we should decide which PR moves forward and then stage to test and review. |
FWIW we were already using 6.2.1 from the Also I think we've already agreed not to use the relaxed requirements for any of the automated builds, right? We should use relaxed for test builds and locals. So #329 is a separate thing. |
So we do want less-pinned builds for devel, and the stable (what we used to call known-good because.. we knew it would work) for stable branch builds. that is - we still want the canary in the coal mine build on devel. Like we discovered sphinx 7.2.2 doesn't work, and adapted around it. |
Approved if you want to merge, but I do think we should jump to 7.1.2 on devel soonish as well (on devel). |
Resolves #267