ci: refresh docs build dependencies #316
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Yes. |
|
FWIW a common workaround is to use https://github.com/marketplace/actions/github-app-token. |
github-actions
bot
added
the
needs_triage
|
I toggled the PR to trigger CI. We can come up with a better solution in the future. |
There was a problem hiding this comment.
Hmm. I think this is OK but a little premature or something.
The logic of the docs build jobs on Jenkins (cannot wait to get community visibility into them) has been like this:
If devel, install requirements from docs/docsite/requirements.txt
If stable, install requirements from either tests or the good known reqs file (stable-2.14 only).
Now the relaxed requirements are in place, we can remove the docs/docsite/requirements.txt file. However we still need to bump the sphinx version in the lockfile to match what was previously on devel. I captured it in this issue: #267
I feel like we should do that first and will send a PR. I'd prefer to finish cleaning up a little before we merge this so it isn't such a big jump between sphinx versions.
I also feel like PRs that bump sphinx to a new major version should get built on test and have a defined soak time. @samccann Maybe we could come up with a sanity checklist of things to look for in the docs build?
|
We can't merge this until the build works with sphinx 7.2.2 And yes, all changes to requirements must be fully tested and verified on a staged build to the test site. |
github-actions
bot
force-pushed
the
pip-compile/devel/docs
branch
from
5ccd223 to
76967e8
Compare
github-actions
bot
force-pushed
the
pip-compile/devel/docs
branch
from
76967e8 to
e1e8657
Compare
|
I'm removing the draft status. All this PR does is update the requiremented-relaxed file which are not used in production and only for local tests. I did a test coredocs build locally and confirmed that this works properly.
This now only bumps the sphinx version to 7.1.2. |
This is based on ansible#316 but only changes requirements-relaxed.txt. (cherry picked from commit e1e8657)
|
Thank you @gotmax23 |
No description provided.