Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update server code to use newer ansible-creator>=24.10.0 #415

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

Update server code to use newer ansible-creator>=24.10.0 #415

wants to merge 9 commits into from
+81 −17

Conversation

shatakshiiii
Copy link
Contributor

@shatakshiiii shatakshiiii commented Oct 11, 2024 •
edited
Loading

@ssbarnea ssbarnea changed the title update server code Update server code to use newer ansible-creator>=24.10.0 Oct 11, 2024
@ssbarnea ssbarnea added the bug Something isn't working label Oct 11, 2024
ssbarnea
ssbarnea requested changes Oct 13, 2024
View reviewed changes
Copy link
Member

@ssbarnea ssbarnea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please ensure the /v1 call still works and that /v2 on is also tested. No issue to require minimum version of ansible-creator to be the newer one but we need to keep the server backwards compatible.

@shatakshiiii shatakshiiii self-assigned this Oct 15, 2024
@shatakshiiii shatakshiiii added enhancement New feature or request and removed bug Something isn't working labels Oct 15, 2024
@shatakshiiii shatakshiiii mentioned this pull request Oct 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssbarnea ssbarnea ssbarnea requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@shatakshiiii shatakshiiii

Labels
enhancement New feature or request
Projects
🧰 devtools project board
Status: In Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shatakshiiii @ssbarnea