Upgrade ansible-lint to 6.20.1 #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TamiTakamiya
commented
Sep 29, 2023
| @@ -78,7 +78,7 @@ repos: | |||
| additional_dependencies: | |||
| - pytest | |||
| - tox | |||
| - ansible-lint | |||
| - ansible-lint>=6.20.1 | |||
There was a problem hiding this comment.
Though I did not want to add a version number here, pylint failed in my environment without this change.
TamiTakamiya
commented
Sep 29, 2023
| @@ -49,7 +49,7 @@ def ansiblelint_main(argv: list[str] | None = None) -> LintResult: | |||
|
|
|||
| # pylint: disable=import-outside-toplevel | |||
| from ansiblelint.rules import RulesCollection | |||
| from ansiblelint.runner import _get_matches | |||
| from ansiblelint.runner import get_matches | |||
There was a problem hiding this comment.
This is the method we are using.
TamiTakamiya
deleted the
ttakamiy/AAP-16653/update-ansible-lint-to-6.20.1
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For AAP-16653.
Since this change in this version of ansible-lint changed a name of a method that was used in Content Parser (well, we should not have used it because the method name started with
_...), we need to make a small change in our code.