Replace --skip-transform option with --fix #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TamiTakamiya
commented
Sep 26, 2023
| "with the --fix option and files are transformed according to the rules specified.", | ||
| "--fix", | ||
| dest="write_list", # This is how this option is stored in ansible_lint. | ||
| # default="all", <-- Commented out because this does not work as expected. |
There was a problem hiding this comment.
I expected "all" will be set to args.write_list by default when default="all" is specified, but it does not set anything unless --fix option is explicitly set.
TamiTakamiya
commented
Sep 26, 2023
| @@ -396,8 +399,10 @@ def parse_sarif_json(exclude_paths: list[str], sarif_file: str) -> None: | |||
|
|
|||
| def update_argv(argv: list[str], args: argparse.Namespace) -> None: | |||
| """Update arguments to ansible-lint based on arguments given to ansible-content-parser.""" | |||
| if not args.skip_transform: | |||
| if getattr(args, "write_list", None) is None: | |||
There was a problem hiding this comment.
This is how I set the default value (=all) to write_list.
robinbobbitt
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For AAP-16412.
This will replace the
--skip-transformoption with the--fixoption. While the--skip-transformoption was for turning on/off the transform feature ofansible-lint, the new--fixoption provides more flexibility (including turning on/off) by just passing the specified parameters toansible-lint.