-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove isolated option while adding sys.path #335
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do not want to lower the code coverage, removing of the test is a very bad idea and coverage was there to remind us not to make this mistake.
The correct solution for this is to modify the tests to check for the new behavior instead of removing them.
Removing the conditional allows the number of tests to be dropped. As time permits, please add a test or 2 in a seperate PR to return coverage to it's previous value or higher. |
@ssbarnea ^^^ Also I realized that the changes in this PR is not responsible for lowering the code coverage, as I can see same codecov failure in other open PRs as well. And dropping some unnecessary tests is suppose to happen as per these code changes. |
This PR validates the usage of
isolated
while adding sys.path to collections path.Closes: #324