Remove empty values after param validation #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After the populated config is validated with module argspec remove the empty values for rendered facts
|
Build succeeded.
|
NilashishC
reviewed
Jul 1, 2019
| @@ -73,8 +73,10 @@ class {{ resource|capitalize }}Facts(object): | |||
| objs.append(obj) | |||
| facts = {} | |||
| if objs: | |||
| facts['{{ resource }}'] = [] | |||
There was a problem hiding this comment.
Quick question: Would this break for facts with are inherently not a list of items (e.g., lacp)?
There was a problem hiding this comment.
By default, the value stored for the fact is a list of dict. In case the fact is not a list item it is converted to list of dict and stored in facts as per the current logic. Adding this line won't change existing behavior.
trishnaguha
approved these changes
Jul 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the populated config is validated with
module argspec remove the empty values for
rendered facts