-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow for custom providers hosted on maven repositories #223
Merged
guidograzioli
merged 5 commits into
ansible-middleware:main
from
world-direct:feature/222_mvn_providers
May 15, 2024
Merged
Allow for custom providers hosted on maven repositories #223
guidograzioli
merged 5 commits into
ansible-middleware:main
from
world-direct:feature/222_mvn_providers
May 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hwo-wd
changed the title
Feature/222 mvn providers
Feature/222 keycloak_quarkus: Add support for custom providers hosted on MVN
May 13, 2024
We now support three different kinds of providers:
I think this pretty much covers the majority of use cases;
|
hwo-wd
force-pushed
the
feature/222_mvn_providers
branch
from
May 14, 2024 08:14
8eb6efe
to
d87c8ca
Compare
hwo-wd
force-pushed
the
feature/222_mvn_providers
branch
from
May 14, 2024 09:58
317c041
to
6ca99c0
Compare
hwo-wd
force-pushed
the
feature/222_mvn_providers
branch
2 times, most recently
from
May 14, 2024 18:29
4769c48
to
f962bde
Compare
hwo-wd
force-pushed
the
feature/222_mvn_providers
branch
from
May 14, 2024 18:33
f962bde
to
d2ece93
Compare
guidograzioli
approved these changes
May 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all good
guidograzioli
added
the
major_changes
Major changes mean the user can CHOOSE to make a change when they update but do not have to
label
May 15, 2024
guidograzioli
changed the title
Feature/222 keycloak_quarkus: Add support for custom providers hosted on MVN
Allow for custom providers hosted on maven repositories
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
major_changes
Major changes mean the user can CHOOSE to make a change when they update but do not have to
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends support for custom providers ("SPIs"): while previously only http downloads were supported, the new provider definition allows for maven downloads (e.g., Apache Maven Central, Github Apache Maven (requires authn via a PAT)).
The new providers definition looks like:
lxml
is a new python dependency for this collection (however, it was already present because it is also a dependency ofmiddleware_automation.common
Close #222