Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New activemq_uninstall role #150

Merged
merged 6 commits into from
Aug 19, 2024

Conversation

guidograzioli
Copy link
Member

The activemq_uninstall role is meant to clean deployments that were executed by the activemq role.
It accepts the same parameters as the activemq role:

Variable Description Default
activemq_version Apache Artemis version 2.34.0
activemq_archive Apache Artemis install archive filename apache-artemis-{{ activemq_version }}-bin.zip
activemq_installdir Apache Artemis Installation path {{ activemq_dest }}/apache-artemis-{{ activemq_version }}
activemq_dest Root installation directory /opt/amq
activemq_service_user POSIX user running the service amq-broker
activemq_service_group POSIX group running the service amq-broker
activemq_service_name systemd service unit name activemq
activemq_service_user_home Service user home directory, defaults to artemis installation directory {{ activemq_dest }}/apache-artemis-{{ activemq_version }}
activemq_instance_name Name of broker instance to deploy amq-broker
activemq_configure_firewalld Whether to install and configure firewalld False
activemq_shared_storage Use shared filesystem directory for storage False
activemq_shared_storage_path Absolute path of shared directory {{ activemq_dest }}/{{ activemq_instance_name }}/data/shared
activemq_shared_storage_mounted Whether the systemd unit must require a mounted path (only when using shared storage) True

and additionally:

Variable Description Default
activemq_uninstall_skip_user Whether to skip user/group account deletion false
activemq_uninstall_skip_zipfile Whether to skip installation zipfile deletion false
activemq_uninstall_skip_artemis Whether to skip artemis directory deletion false

Fix #138

@guidograzioli guidograzioli added the major_changes Major changes mean the user can CHOOSE to make a change when they update but do not have to label Aug 19, 2024
Copy link
Contributor

@rpelisse rpelisse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

filter: "msgType LIKE '%ff%'"
exclusive: True
roles:
- middleware_automation.amq.activemq
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is not the new "good" syntax like that:

roles:
  - name: middleware_automation.amq.activemq

?

---
- hosts: all
roles:
- middleware_automation.amq.activemq_uninstall
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same remark on the role inclusion syntax.

@guidograzioli guidograzioli merged commit 3ce8ba2 into ansible-middleware:main Aug 19, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major_changes Major changes mean the user can CHOOSE to make a change when they update but do not have to
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement an option to undo/remove/cleanup the installation
2 participants