This repository has been archived by the owner on Jan 8, 2023. It is now read-only.
Lazily load podman executable #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssbarnea
approved these changes
Sep 5, 2021
NikolineLykPedersen
approved these changes
Sep 5, 2021
When we introduced the ability to specify podman executable, we inadvertently changed the behavior of the loading mechanism (commit e120aa1). Before that change, it was possible to initialize the podman driver even if the podman executable was not present. In other words, it was OK to install the podman driver without having podman installed on the system. With the new mechanism in place, Molecule will fail to start when the podman driver is installed and there is no podman executable available on the system. This commit restores the od lazy-loading behavior.
tadeboro
force-pushed
the
lazy-load-podman-executable
branch
from
94aeef4 to
0009c2a
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we introduced the ability to specify podman executable, we inadvertently changed the behavior of the loading mechanism (commit e120aa1).
Before that change, it was possible to initialize the podman driver even if the podman executable was not present. In other words, it was OK to install the podman driver without having podman installed on the system.
With the new mechanism in place, Molecule will fail to start when the podman driver is installed and there is no podman executable available on the system.
This commit restores the od lazy-loading behavior.
Fixes #81