Skip to content
This repository has been archived by the owner on Jan 8, 2023. It is now read-only.

TERM=bash in driver.py looks like a mistake #104

Closed
aburch opened this issue Jan 26, 2022 · 1 comment · Fixed by #128
Closed

TERM=bash in driver.py looks like a mistake #104

aburch opened this issue Jan 26, 2022 · 1 comment · Fixed by #128
Labels
bug This issue/PR relates to a bug.

Comments

@aburch
Copy link
Contributor

aburch commented Jan 26, 2022

driver.py sets TERM=bash and then TERM=xterm in the next line:

    @property
    def login_cmd_template(self):
        return (
            f"{self.podman_cmd} exec "
            "-e COLUMNS={columns} "
            "-e LINES={lines} "
            "-e TERM=bash "
            "-e TERM=xterm "
            "-ti {instance} bash"
        )

This should probably be SHELL=bash?

@ssbarnea
Copy link
Member

@aburch You are right, the real question is why you did not open a pull request to fix it?

@ssbarnea ssbarnea added the bug This issue/PR relates to a bug. label Jul 18, 2022
aburch added a commit to aburch/molecule-podman that referenced this issue Jul 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug This issue/PR relates to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants