workflow shared-docs-build-push: add artifact-upload
and build-ref
options
#45
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modifies the push build workflow so that you can:
true
, no change in behavior)These changes make the workflow useful for running a "validation" job, by changing the lenient and fail-on-error options. This was already possible for push workflows, but the artifact uploaded was redundant and couldn't be turned off.
For PRs, this was not possible with
pull_request_target
events (which we usually use) because we had no way to tell the workflow to use the PR ref (the default would have been the PR target, likemain
). Now we can tell the workflow to use the merge commit or whatever on PRs.Examples
(Currently shown referencing this PR's version of the workflow)
PR
Push