Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Galaxy downloader: if a collection is found in the cache but the hash doesn't match, do not return nonexistent path #76

Merged
merged 1 commit into from
Apr 28, 2023
Merged

Galaxy downloader: if a collection is found in the cache but the hash doesn't match, do not return nonexistent path #76

merged 1 commit into from
Apr 28, 2023

Conversation

felixfontein
Copy link
Collaborator

No description provided.

@felixfontein felixfontein added the backport-1 Automatically create backport to stable-1 branch label Apr 28, 2023
gotmax23
gotmax23 approved these changes Apr 28, 2023
View reviewed changes
Copy link
Collaborator

@gotmax23 gotmax23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack, but s/non-existing/nonexistent/ in the commit message.

@felixfontein felixfontein changed the title Galaxy downloader: if a collection is found in the cache but the hash doesn't match, do not return non-existing path Galaxy downloader: if a collection is found in the cache but the hash doesn't match, do not return nonexistent path Apr 28, 2023
@felixfontein felixfontein merged commit 42b8f22 into ansible-community:main Apr 28, 2023
@patchback
Copy link

patchback bot commented Apr 28, 2023 •
edited
Loading

Backport to stable-1: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-1/42b8f22cf2a999c8d97fb91c4d0eb6e475b148b7/pr-76

Backported as #77

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Apr 28, 2023
@felixfontein @patchback
If a collection is found in the cache but the hash doesn't match, do …
bbb6de3 
…not return a path to a non-existing file. (#76)

(cherry picked from commit 42b8f22)
@patchback patchback bot mentioned this pull request Apr 28, 2023
Merged
@felixfontein felixfontein deleted the fix branch April 28, 2023 14:24
@felixfontein
Copy link
Collaborator Author

@gotmax23 thanks for reviewing this!

felixfontein added a commit that referenced this pull request Apr 29, 2023
@patchback @felixfontein
If a collection is found in the cache but the hash doesn't match, do …
50cedb8 
…not return a path to a non-existing file. (#76) (#77)

(cherry picked from commit 42b8f22)

Co-authored-by: Felix Fontein <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gotmax23 gotmax23 gotmax23 approved these changes

Assignees
No one assigned
Labels
backport-1 Automatically create backport to stable-1 branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@felixfontein @gotmax23