remove improper usage of @cache on async functions #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Neither functools.cache nor functools.lru_cache which was previously used here works properly with async functions. These decorators cache the coroutine, but coroutines can only be awaited once, so this falls apart. Take the following example: ``` In [1]: from functools import cache In [2]: @cache ...: async def abc(): ...: return 1234 ...: In [3]: print(await abc()) 1234 In [4]: print(await abc()) --------------------------------------------------------------------------- RuntimeError Traceback (most recent call last) Cell In[4], line 1 ----> 1 print(await abc()) RuntimeError: cannot reuse already awaited coroutine ```
|
This should be backported to stable-1 IMO, but it'll have to be done manually |
|
Thanks for doing this! |
gotmax23
added a commit
to gotmax23/antsibull-core
that referenced
this pull request
Apr 19, 2023
) * remove improper usage of @cache on async functions Neither functools.cache nor functools.lru_cache which was previously used here works properly with async functions. These decorators cache the coroutine, but coroutines can only be awaited once, so this falls apart. Take the following example: ``` In [1]: from functools import cache In [2]: @cache ...: async def abc(): ...: return 1234 ...: In [3]: print(await abc()) 1234 In [4]: print(await abc()) --------------------------------------------------------------------------- RuntimeError Traceback (most recent call last) Cell In[4], line 1 ----> 1 print(await abc()) RuntimeError: cannot reuse already awaited coroutine ``` * Fix changelog. --------- Co-authored-by: Felix Fontein <[email protected]>
felixfontein
added a commit
that referenced
this pull request
Apr 19, 2023
) * remove improper usage of @cache on async functions (#67) * remove improper usage of @cache on async functions Neither functools.cache nor functools.lru_cache which was previously used here works properly with async functions. These decorators cache the coroutine, but coroutines can only be awaited once, so this falls apart. Take the following example: ``` In [1]: from functools import cache In [2]: @cache ...: async def abc(): ...: return 1234 ...: In [3]: print(await abc()) 1234 In [4]: print(await abc()) --------------------------------------------------------------------------- RuntimeError Traceback (most recent call last) Cell In[4], line 1 ----> 1 print(await abc()) RuntimeError: cannot reuse already awaited coroutine ``` * Fix changelog. --------- Co-authored-by: Felix Fontein <[email protected]> * update changelog entry --------- Co-authored-by: Felix Fontein <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Neither functools.cache nor functools.lru_cache which was previously
used here works properly with async functions. These decorators cache
the coroutine, but coroutines can only be awaited once, so this falls
apart.
Take the following example: