venv: prepare for sh removal and add tests #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@felixfontein, can you take a cursory look before I clean this up and write a changelog frag? I'm not sure if you had something else in mind. |
|
@gotmax23 looks good to me! |
This was referenced Apr 9, 2023
gotmax23
force-pushed
the
new_venv
branch
3 times, most recently
from
25c86df to
28bb17e
Compare
- Deprecate the `get_command` methods on VenvRunner and FakeVenvRunner - Add new `async_log_run` and `log_run` methods to replace the former. These work the same as their counterparts in `antsibull_core.subprocess_util`, but the VenvRunner version enforces a clean environment and requires paths to be installed in the venv.
felixfontein
approved these changes
Apr 9, 2023
|
@gotmax23 thanks for creating this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_commandmethods on VenvRunner and FakeVenvRunnerasync_log_runandlog_runmethods to replace the former.These work the same as their counterparts in
antsibull_core.subprocess_util, but the VenvRunner version enforcesa clean environment and requires paths to be installed in the venv.