add subprocess_util module to replace sh #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I want to add unit tests but I don't think |
gotmax23
force-pushed
the
subprocess_util
branch
5 times, most recently
from
4e005b3 to
4d1f1fc
Compare
|
I was very perturbed as to why the tests were failing in CI but locally, but I guess |
This adds code to run subprocesses asynchronously and integrates with the logger. stdout and stderr are logged in real time and always captured. We return a CompletedProcess object like regular subprocess does. Relates: ansible-community#34
Both Logger classes have `.debug()`, `.info()`, etc. methods, so let's explicitly declare support for both.
gotmax23
force-pushed
the
subprocess_util
branch
from
4d1f1fc to
d240363
Compare
gotmax23
changed the title
felixfontein
approved these changes
Apr 5, 2023
|
@gotmax23 thanks for adding this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds code to run subprocesses asynchronously and integrates with the logger. stdout and stderr are logged in real time and always captured. We return a CompletedProcess object like regular subprocess does.
Relates: #34