Add collection meta code #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
gotmax23
reviewed
Sep 11, 2024
| removal: | ||
| major_version: 11 | ||
| reason: other | ||
| reason_text: The collection wasn't cow friendly, so the Steering Committee decided to kick it out. |
| collection_metadata: str, | ||
| all_collections: list[str], | ||
| expected_errors: list[str], | ||
| tmp_path, |
There was a problem hiding this comment.
I usually annotate fixtures (and import Path from pathlib in this case), but that's up to you.
Suggested change
| tmp_path, | |
| tmp_path: Path, |
Comment on lines
145
to
146
| if not os.path.exists(collection_meta_path): | ||
| return [f"Cannot find {collection_meta_path}"] |
There was a problem hiding this comment.
Noticing this now: it would be more efficient if this was moved to the top of the function.
There was a problem hiding this comment.
Originally the path was only composed at this point, so it maked sense to have that test there. Since it's now passed in, it definitely makes sense!
Co-authored-by: Maxwell G <[email protected]>
Co-authored-by: Maxwell G <[email protected]>
|
@gotmax23 thanks for reviewing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to ansible-community/antsibull-build#617. Used by ansible-community/antsibull-build#620.