Fix overly restrictive file name types #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What is the test.yml for? Also, can you please add a changelog fragment? Thanks. |
It's for people who don't check which files they've staged before committing :). I'll remove that and write a changelog fragment. |
StrOrBytesPath encompasses str, bytes, and PathLike objects, which are valid inputs to open(). There's likely more of these that should be fixed, but this is some of them.
Co-authored-by: Felix Fontein <[email protected]>
felixfontein
approved these changes
Nov 26, 2022
|
@gotmax23 thanks for this improvement! |
|
Thanks for reviewing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StrOrBytesPath encompasses str, bytes, and PathLike file names, which are valid inputs to open(). There's likely more of these that should be fixed, but this is some of them. I'd like to use pathlib in my source distribution code so that's my motivation here :).