deprecate support for old ansible versions <6.0.0 #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gotmax23
force-pushed
the
old-ansible-dep
branch
from
4d24afe to
26a3a1e
Compare
|
Instead of deprecating, it we should probably outright remove it. Ansible >= 6 means ansible-core >= 2.13, and the only known users of antsibull-core (antsibull and antsibull-docs) don't support ansible-core < 2.13 anymore. If someone else is using antsibull-core and needs these features, they can always restrict to |
|
Ah, I meant to target this PR against stable-2. |
|
Fixed |
|
Looks good to me. Not sure whether we really need to explicitly deprecate this before removing it from v3 though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates: #123