Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Sequence[] instead of list[] for lists of StrPath #112

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

felixfontein
Copy link
Collaborator

Follow-up to #105, which broke type checks for antsibull:

src/antsibull/build_ansible_commands.py:656: error: Argument 1 to "install_together" has incompatible type "list[str]"; expected "list[str | PathLike[str]]"  [arg-type]
src/antsibull/build_ansible_commands.py:656: note: "List" is invariant -- see https://mypy.readthedocs.io/en/stable/common_issues.html#variance
src/antsibull/build_ansible_commands.py:656: note: Consider using "Sequence" instead, which is covariant

(https://github.com/ansible-community/antsibull/actions/runs/6766190684/job/18386917570)

@felixfontein felixfontein requested a review from gotmax23 November 6, 2023 05:15
@gotmax23 gotmax23 merged commit 14df3ac into ansible-community:main Nov 6, 2023
4 of 5 checks passed
@felixfontein felixfontein deleted the path branch November 6, 2023 17:59
@felixfontein
Copy link
Collaborator Author

@gotmax23 thanks a lot for reviewing and merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants