New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typing for app_context #109

Merged

felixfontein merged 2 commits into ansible-community:main from felixfontein:typing

Oct 15, 2023

Collaborator

felixfontein commented Oct 15, 2023

Currently the typing checks fail on main (see for example https://github.com/ansible-community/antsibull-core/actions/runs/6478324868/job/17589911927?pr=105). (Having @contextmanager in the overloads transforms the typing of the function stub. Also typing.ContextManager is a deprecated alias for contextlib.AbstractContextManager.)

felixfontein added 2 commits

October 15, 2023 13:42


          Fix typing for app_context.

afab025


          Add changelog fragment.

0b9fc9a

gotmax23 approved these changes

View reviewed changes

felixfontein merged commit 7ce1fc5 into ansible-community:main

5 checks passed

felixfontein deleted the typing branch

October 15, 2023 19:23

Collaborator Author

felixfontein commented Oct 15, 2023

@gotmax23 thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet