Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ansible 8: allow dellemc.enterprise_sonic != 2.1.0 #245

Merged
merged 2 commits into from
Jun 2, 2023

Conversation

felixfontein
Copy link
Contributor

@felixfontein felixfontein commented Jun 1, 2023

The breaking change in dellemc.enterprise_sonic has been reverted (see ansible-collections/dellemc.enterprise_sonic#268), and the restriction to ansible.netcommon < 5.0.0 has been lifted (see #233). Therefore we remove the pin to 2.0.0 for Ansible 8.

Resolves ansible-collections/dellemc.enterprise_sonic#267
Resolves ansible-collections/dellemc.enterprise_sonic#268
Resolves #233

@felixfontein
Copy link
Contributor Author

felixfontein commented Jun 1, 2023

I just noticed that the GH release for 2.2.0 is there (https://github.com/ansible-collections/dellemc.enterprise_sonic/releases/tag/2.2.0), but the Galaxy release isn't (https://galaxy.ansible.com/dellemc/enterprise_sonic). So this shouldn't be merged until the release is there.

@felixfontein felixfontein marked this pull request as draft June 1, 2023 20:21
@felixfontein felixfontein marked this pull request as ready for review June 2, 2023 05:16
@felixfontein
Copy link
Contributor Author

2.2.0 is now on Galaxy as well.

@felixfontein felixfontein reopened this Jun 2, 2023
@felixfontein felixfontein requested a review from gotmax23 June 2, 2023 11:33
8/changelog.yaml Outdated Show resolved Hide resolved
Co-authored-by: Maxwell G <[email protected]>
@felixfontein felixfontein merged commit d571a2b into ansible-community:main Jun 2, 2023
@felixfontein felixfontein deleted the dellemc branch June 2, 2023 19:04
@felixfontein
Copy link
Contributor Author

@kerry-meyer thanks for getting the issues fixed!
@gotmax23 thanks for reviewing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants