Add Attachments #91
Merged
Add Attachments #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Akasurde
reviewed
Aug 4, 2021
tests/integration/targets/attachment/res/sample_file_changed.txt
Outdated
Show resolved
Hide resolved
Add an attachment management to modules
tadeboro
suggested changes
Aug 17, 2021
There was a problem hiding this comment.
We are almost there yet. I commented on most of the things in the code, but there is still one thing that is missing: one attachment sample call in the EXAMPLES section of each regular module. You can just add that parameter to the existing sample tasks that are already present in the modules.
tadeboro
suggested changes
Aug 17, 2021
tadeboro
approved these changes
Aug 18, 2021
tadeboro
approved these changes
Aug 18, 2021
|
@tadeboro Are we waiting on something here? If not, I can |
Just your LGTM ;) I did not want to gate this PR since you asked me to wait with the merges until you had a chance to review the PRs. |
|
I will gate this once the #99 is merged. |
![ansible-zuul[bot]](https://avatars.githubusercontent.com/in/27800?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Adds an option to add/change attachments to existing modules. Modules that support this feature:
ISSUE TYPE
COMPONENT NAME
Attachments
ADDITIONAL INFORMATION
Supports adding attachments, changing them (when updating a table record that already has a file with the same name attached) and deleting them (when deleting the records they are attached to).
Fixes: #89