Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Certificate validation option #264

Merged
merged 4 commits into from
Jun 19, 2023
Merged

Certificate validation option #264

merged 4 commits into from
Jun 19, 2023

Conversation

PolonaM
Copy link
Contributor

@PolonaM PolonaM commented Jun 14, 2023

SUMMARY

This PR adds validate_certs instance option to avoid error when using self-signed certificate as reported in issue #258.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

module_utils.arguments.py
module_utils.client.py
doc_fragments.instance.py

ADDITIONAL INFORMATION

Closes #258

@PolonaM PolonaM marked this pull request as draft June 14, 2023 14:15
@softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/3e251274386d447191e10195f1d0e46c

✔️ build-ansible-collection SUCCESS in 7m 02s
❌ ansible-test-sanity-docker-devel FAILURE in 9m 46s (non-voting)
❌ ansible-test-sanity-docker-milestone FAILURE in 9m 24s (non-voting)
❌ ansible-test-sanity-docker-stable-2.9 FAILURE in 11m 44s
❌ ansible-test-sanity-docker-stable-2.10 FAILURE in 9m 48s
❌ ansible-test-sanity-docker-stable-2.11 FAILURE in 10m 31s
❌ ansible-test-sanity-docker-stable-2.12 FAILURE in 7m 52s
✔️ ansible-test-units-servicenow-itsm-python27 SUCCESS in 6m 45s
✔️ ansible-test-units-servicenow-itsm-python36 SUCCESS in 6m 24s
✔️ ansible-test-units-servicenow-itsm-python37 SUCCESS in 6m 37s
✔️ ansible-test-units-servicenow-itsm-python38 SUCCESS in 6m 46s
✔️ ansible-galaxy-importer SUCCESS in 4m 09s

@softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/f7a174d8562b46419684791628f16ecc

✔️ build-ansible-collection SUCCESS in 7m 50s
✔️ ansible-test-sanity-docker-devel SUCCESS in 9m 09s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 7m 34s (non-voting)
❌ ansible-test-sanity-docker-stable-2.9 RETRY_LIMIT in 7m 00s
✔️ ansible-test-sanity-docker-stable-2.10 SUCCESS in 9m 47s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 9m 55s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 8m 12s
✔️ ansible-test-units-servicenow-itsm-python27 SUCCESS in 6m 25s
✔️ ansible-test-units-servicenow-itsm-python36 SUCCESS in 4m 20s
✔️ ansible-test-units-servicenow-itsm-python37 SUCCESS in 5m 45s
✔️ ansible-test-units-servicenow-itsm-python38 SUCCESS in 6m 44s
✔️ ansible-galaxy-importer SUCCESS in 3m 32s

@PolonaM PolonaM marked this pull request as ready for review June 15, 2023 07:37
@PolonaM
Copy link
Contributor Author

PolonaM commented Jun 15, 2023

recheck

@softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/17dc5f7f654e463fb0737ffe6522ec21

✔️ build-ansible-collection SUCCESS in 7m 02s
✔️ ansible-test-sanity-docker-devel SUCCESS in 8m 07s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 8m 04s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 10m 49s
✔️ ansible-test-sanity-docker-stable-2.10 SUCCESS in 12m 13s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 10m 12s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 7m 44s
✔️ ansible-test-units-servicenow-itsm-python27 SUCCESS in 5m 36s
✔️ ansible-test-units-servicenow-itsm-python36 SUCCESS in 5m 43s
✔️ ansible-test-units-servicenow-itsm-python37 SUCCESS in 4m 46s
✔️ ansible-test-units-servicenow-itsm-python38 SUCCESS in 5m 02s
✔️ ansible-galaxy-importer SUCCESS in 3m 48s

Akasurde
Akasurde approved these changes Jun 15, 2023
View reviewed changes
Copy link
Member

@Akasurde Akasurde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

juremedvesek
juremedvesek approved these changes Jun 16, 2023
View reviewed changes
Copy link
Contributor

@juremedvesek juremedvesek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@softwarefactory-project-zuul
Copy link

Build failed (gate pipeline). For information on how to proceed, see
http://docs.openstack.org/infra/manual/developers.html#automated-testing

https://ansible.softwarefactory-project.io/zuul/buildset/97d87d14a0304882be994abe462059cf

✔️ build-ansible-collection SUCCESS in 7m 01s
✔️ ansible-test-sanity-docker-devel SUCCESS in 9m 58s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 10m 07s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 12m 21s
✔️ ansible-test-sanity-docker-stable-2.10 SUCCESS in 10m 28s
❌ ansible-test-sanity-docker-stable-2.11 FAILURE in 9m 56s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 7m 56s
✔️ ansible-test-units-servicenow-itsm-python27 SUCCESS in 5m 41s
✔️ ansible-test-units-servicenow-itsm-python36 SUCCESS in 4m 46s
✔️ ansible-test-units-servicenow-itsm-python37 SUCCESS in 5m 19s
✔️ ansible-test-units-servicenow-itsm-python38 SUCCESS in 5m 12s
✔️ ansible-galaxy-importer SUCCESS in 3m 40s

@Akasurde
Copy link
Member

recheck

@Akasurde Akasurde added mergeit and removed mergeit labels Jun 19, 2023
@softwarefactory-project-zuul
Copy link

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/905e5e8d15e94d12a162a21594dd0b7e

✔️ build-ansible-collection SUCCESS in 6m 41s
✔️ ansible-test-sanity-docker-devel SUCCESS in 9m 31s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 9m 28s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 10m 52s
✔️ ansible-test-sanity-docker-stable-2.10 SUCCESS in 10m 27s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 9m 54s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 8m 11s
✔️ ansible-test-units-servicenow-itsm-python27 SUCCESS in 4m 58s
✔️ ansible-test-units-servicenow-itsm-python36 SUCCESS in 6m 04s
✔️ ansible-test-units-servicenow-itsm-python37 SUCCESS in 4m 35s
✔️ ansible-test-units-servicenow-itsm-python38 SUCCESS in 5m 49s
✔️ ansible-galaxy-importer SUCCESS in 3m 26s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit a40d0eb into ansible-collections:main Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juremedvesek juremedvesek juremedvesek approved these changes

@Akasurde Akasurde Akasurde approved these changes

Assignees
No one assigned
Labels
mergeit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Certificate Validation Option
3 participants
@PolonaM @Akasurde @juremedvesek