Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attachment upload module bugfix #260

Merged
merged 4 commits into from
Jun 19, 2023
Merged

Attachment upload module bugfix #260

merged 4 commits into from
Jun 19, 2023

Conversation

PolonaM
Copy link
Contributor

@PolonaM PolonaM commented Jun 9, 2023

SUMMARY

The module wasn't working properly as reported in issue #259. This fix now solves the issue.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

attachment_upload module

@softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/1c3be1ab62fd4142afa11675da52ba56

✔️ build-ansible-collection SUCCESS in 6m 45s
❌ ansible-test-sanity-docker-devel FAILURE in 9m 46s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 9m 50s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 11m 46s
❌ ansible-test-sanity-docker-stable-2.10 FAILURE in 8m 09s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 11m 40s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 10m 28s
✔️ ansible-test-units-servicenow-itsm-python27 SUCCESS in 6m 30s
✔️ ansible-test-units-servicenow-itsm-python36 SUCCESS in 4m 38s
✔️ ansible-test-units-servicenow-itsm-python37 SUCCESS in 7m 38s
✔️ ansible-test-units-servicenow-itsm-python38 SUCCESS in 7m 58s
✔️ ansible-galaxy-importer SUCCESS in 4m 29s

@Akasurde
Copy link
Member

@PolonaM Thanks for the PR. Could you please check the failures in the CI? Thanks.

@juremedvesek
Copy link
Contributor

recheck

@softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/a345f324a0a14b05a2889f328df0a7da

✔️ build-ansible-collection SUCCESS in 6m 42s
✔️ ansible-test-sanity-docker-devel SUCCESS in 9m 18s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 9m 30s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 16m 48s
✔️ ansible-test-sanity-docker-stable-2.10 SUCCESS in 12m 59s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 9m 53s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 9m 12s
✔️ ansible-test-units-servicenow-itsm-python27 SUCCESS in 6m 36s
✔️ ansible-test-units-servicenow-itsm-python36 SUCCESS in 6m 56s
✔️ ansible-test-units-servicenow-itsm-python37 SUCCESS in 7m 04s
✔️ ansible-test-units-servicenow-itsm-python38 SUCCESS in 6m 48s
✔️ ansible-galaxy-importer SUCCESS in 4m 28s

@juremedvesek juremedvesek self-requested a review June 16, 2023 04:45
juremedvesek
juremedvesek approved these changes Jun 16, 2023
View reviewed changes
Copy link
Contributor

@juremedvesek juremedvesek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@softwarefactory-project-zuul
Copy link

Build failed (gate pipeline). For information on how to proceed, see
http://docs.openstack.org/infra/manual/developers.html#automated-testing

https://ansible.softwarefactory-project.io/zuul/buildset/46d00311162945319ffbe90c07f10376

✔️ build-ansible-collection SUCCESS in 7m 33s
✔️ ansible-test-sanity-docker-devel SUCCESS in 10m 33s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 10m 07s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 12m 00s
✔️ ansible-test-sanity-docker-stable-2.10 SUCCESS in 10m 31s
❌ ansible-test-sanity-docker-stable-2.11 FAILURE in 10m 39s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 10m 57s
✔️ ansible-test-units-servicenow-itsm-python27 SUCCESS in 7m 47s
✔️ ansible-test-units-servicenow-itsm-python36 SUCCESS in 8m 14s
✔️ ansible-test-units-servicenow-itsm-python37 SUCCESS in 7m 58s
✔️ ansible-test-units-servicenow-itsm-python38 SUCCESS in 6m 08s
✔️ ansible-galaxy-importer SUCCESS in 5m 10s

@Akasurde Akasurde added mergeit and removed mergeit labels Jun 19, 2023
@softwarefactory-project-zuul
Copy link

Build failed (gate pipeline). For information on how to proceed, see
http://docs.openstack.org/infra/manual/developers.html#automated-testing

https://ansible.softwarefactory-project.io/zuul/buildset/788ef69f08494773a16a43e3b94358ce

✔️ build-ansible-collection SUCCESS in 6m 49s
✔️ ansible-test-sanity-docker-devel SUCCESS in 8m 57s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 8m 30s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 10m 36s
✔️ ansible-test-sanity-docker-stable-2.10 SUCCESS in 9m 45s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 10m 15s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 8m 17s
✔️ ansible-test-units-servicenow-itsm-python27 SUCCESS in 6m 22s
✔️ ansible-test-units-servicenow-itsm-python36 SUCCESS in 5m 54s
❌ ansible-test-units-servicenow-itsm-python37 RETRY_LIMIT in 7m 05s
✔️ ansible-test-units-servicenow-itsm-python38 SUCCESS in 5m 31s
✔️ ansible-galaxy-importer SUCCESS in 4m 14s

@Akasurde Akasurde removed the mergeit label Jun 19, 2023
@Akasurde
Copy link
Member

recheck

@softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/211011c690e64ad0bd35221558444471

✔️ build-ansible-collection SUCCESS in 6m 41s
✔️ ansible-test-sanity-docker-devel SUCCESS in 10m 19s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 9m 48s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 12m 23s
✔️ ansible-test-sanity-docker-stable-2.10 SUCCESS in 11m 13s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 10m 25s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 10m 00s
✔️ ansible-test-units-servicenow-itsm-python27 SUCCESS in 5m 04s
✔️ ansible-test-units-servicenow-itsm-python36 SUCCESS in 6m 05s
✔️ ansible-test-units-servicenow-itsm-python37 SUCCESS in 4m 56s
✔️ ansible-test-units-servicenow-itsm-python38 SUCCESS in 6m 47s
✔️ ansible-galaxy-importer SUCCESS in 4m 00s

@softwarefactory-project-zuul
Copy link

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/50bf4106dd1c432495ab87156043f82b

✔️ build-ansible-collection SUCCESS in 7m 16s
✔️ ansible-test-sanity-docker-devel SUCCESS in 9m 53s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 9m 44s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 11m 57s
✔️ ansible-test-sanity-docker-stable-2.10 SUCCESS in 9m 42s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 11m 02s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 8m 46s
✔️ ansible-test-units-servicenow-itsm-python27 SUCCESS in 6m 39s
✔️ ansible-test-units-servicenow-itsm-python36 SUCCESS in 6m 21s
✔️ ansible-test-units-servicenow-itsm-python37 SUCCESS in 6m 08s
✔️ ansible-test-units-servicenow-itsm-python38 SUCCESS in 7m 02s
✔️ ansible-galaxy-importer SUCCESS in 3m 48s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit b3609a9 into ansible-collections:main Jun 19, 2023
@Akasurde Akasurde mentioned this pull request Jun 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juremedvesek juremedvesek juremedvesek approved these changes

@Akasurde Akasurde Akasurde approved these changes

Assignees
No one assigned
Labels
mergeit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PolonaM @Akasurde @juremedvesek