add return_fields parmeter to the configuration_item_info module #208
Conversation
|
Build succeeded. ✔️ build-ansible-collection SUCCESS in 3m 01s |
There was a problem hiding this comment.
Could you please add tests and create a changelog fragment. See this fragment as an example?
Akasurde
force-pushed
the
add_return_fields_to_configuration_item_info
branch
from
62a799f
to
36f0eca
Compare
* Allow user to specify return fields for the specifed configuration item info Signed-off-by: Toni Moreno Giménez <[email protected]> Signed-off-by: Abhijeet Kasurde <[email protected]>
Akasurde
force-pushed
the
add_return_fields_to_configuration_item_info
branch
from
36f0eca
to
ce1aacf
Compare
Akasurde
requested review from
mhjacks,
tupyy and
Akasurde
and removed request for
juremedvesek
|
/lgtm |
This commit adds integration tests for PR#208.
This commit adds integration tests for PR#208.
This commit adds integration tests for PR #208.
SUMMARY
add return_fields parmeter to the configuration_item_info module, needed for choose only needed information It will speed considerably the response. and the returned data to process. It will be needed to build data maintentance proceses with heavily loaded classes.
Implements #100
ISSUE TYPE
COMPONENT NAME
configuration_item_info
ADDITIONAL INFORMATION
Consider a data process to update info only some ci's with operational_status="opeational" , you need first query the complete class and after do something in a loop with the sys_id of each CI.
Time taken to execute this playbook with "return_fields" : 4.405 seconds
Time taken to execute this playbook without "return_fields" : 11.94 seconds ( only with 6 ci's !!!)
we can guess what will happend when exected this query on a class with 100K registers.
result with return_fields
{ "changed": false, "failed": false, "records": [ { "name": "AAACDB3-PDB21-OTHER2", "operational_status": "operational", "sys_id": "68520d8197651110968b74400153af66" }, { "name": "AAACDB2-PDB22-KKNEW", "operational_status": "operational", "sys_id": "6a29040107a01110befff6fd7c1ed070" }, { "name": "AAACDB1-PDB11-ABEL", "operational_status": "operational", "sys_id": "9bb1fee807241110befff6fd7c1ed089" }, { "name": "AAACDB2-PDB22-TEST1", "operational_status": "operational", "sys_id": "d16a945e07815110befff6fd7c1ed0a4" }, { "name": "AAACDB3-PDB21-OTHER", "operational_status": "operational", "sys_id": "f16a945e07815110befff6fd7c1ed0a7" }, { "name": "AAACDB1-PDB12-TEST2", "operational_status": "operational", "sys_id": "fac2be2c07241110befff6fd7c1ed0a9" } ] }result without return_fields