Change default path handling for existing AD objs #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes the behaviour of path for existing objects when no path was specified and identity points to a valid object. The old behaviour was to treat no path value as the default container for that object type which would have resulted in moving the object. The new behaviour will treat no path or empty path value as keep the existing path. The object will only be moved if an explicit path value was set. Adds support for the sentinel value microsoft.ad.default_path to be specified as the path which will be the default container for that object type.
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 20s |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Changes the behaviour of path for existing objects when no path was specified and identity points to a valid object. The old behaviour was to treat no path value as the default container for that object type which would have resulted in moving the object. The new behaviour will treat no path or empty path value as keep the existing path. The object will only be moved if an explicit path value was set.
Adds support for the sentinel value microsoft.ad.default_path to be specified as the path which will be the default container for that object type.
Fixes: #43
Fixes: #44
Fixes: #52
Fixes: #53
ISSUE TYPE
COMPONENT NAME
microsoft.ad._ADObject